Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/typescript): Preserve default value of an exported binding in a namespace #8029

Merged
merged 4 commits into from
Sep 29, 2023
Merged

fix(es/typescript): Preserve default value of an exported binding in a namespace #8029

merged 4 commits into from
Sep 29, 2023
+138 −127

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Sep 29, 2023 •
edited by kdy1
Loading

@kdy1 kdy1 added this to the Planned milestone Sep 29, 2023
@magic-akari magic-akari marked this pull request as ready for review September 29, 2023 12:19
kdy1
kdy1 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_typescript

@kdy1 kdy1 changed the title fix(es/typescript): Preserve default value in namespace exported binding fix(es/typescript): Preserve default value of an exported binding in a namespace Sep 29, 2023
@kdy1 kdy1 enabled auto-merge (squash) September 29, 2023 19:32
swc-bot
swc-bot reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit cf96171 into swc-project:main Sep 29, 2023
250 checks passed
@magic-akari magic-akari deleted the fix/issue-8025 branch September 29, 2023 22:15
@kdy1 kdy1 modified the milestones: Planned, v1.3.91 Oct 1, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.91
Development

Successfully merging this pull request may close these issues.

Default value not preserved in TypeScript exported binding
3 participants
@magic-akari @kdy1 @swc-bot