Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/ast): Fix definition of SetterProp #8314

Merged
merged 26 commits into from
Jan 19, 2024
Merged

fix(es/ast): Fix definition of SetterProp #8314

merged 26 commits into from
Jan 19, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 20, 2023 •
edited
Loading

@kdy1 kdy1 added this to the Planned milestone Nov 20, 2023
@kdy1 kdy1 self-assigned this Nov 20, 2023
kdy1
kdy1 commented Nov 21, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_ast --breaking

kdy1
kdy1 commented Nov 21, 2023
View reviewed changes
crates/swc_ecma_parser/src/parser/object.rs
Comment on lines -358 to -361
params.retain(|p| match &p.pat {
Pat::Ident(p) => p.sym != "this",
_ => true,
});
Copy link
Member Author

@kdy1 kdy1 Nov 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of this code is the fix of this PR.

@kdy1 kdy1 marked this pull request as ready for review November 27, 2023 05:00
@kdy1 kdy1 requested review from a team as code owners November 27, 2023 05:00
kdy1
kdy1 commented Nov 27, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdy1 kdy1 marked this pull request as draft January 3, 2024 19:54
@kdy1 kdy1 changed the base branch from main to dev January 19, 2024 05:10
@kdy1 kdy1 marked this pull request as ready for review January 19, 2024 05:53
@kdy1 kdy1 merged commit bec4261 into swc-project:dev Jan 19, 2024
17 of 18 checks passed
@kdy1 kdy1 deleted the es-ast branch January 19, 2024 06:06
@kdy1 kdy1 mentioned this pull request Jan 19, 2024
Merged
@kdy1 kdy1 modified the milestones: Planned, v1.3.105 Jan 21, 2024
kdy1 added a commit that referenced this pull request Jan 21, 2024
@kdy1
fix(es/ast): Fix definition of SetterProp (#8314)
bc38ac9 
**Related issue:**

 - Closes #8157
 - Closes #8377
@kdy1 kdy1 mentioned this pull request Jan 24, 2024
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelangeloio michaelangeloio michaelangeloio left review comments

@Austaras Austaras Austaras left review comments

@magic-akari magic-akari magic-akari left review comments

@dsherret dsherret dsherret left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.105
Development

Successfully merging this pull request may close these issues.

Unexpected enum variant in AssignExpr AST of SetterProp is wrong
5 participants
@kdy1 @dsherret @magic-akari @Austaras @michaelangeloio