Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Visit RHS while hoisting properties #9032

Merged
merged 6 commits into from
Jun 11, 2024
Merged

fix(es/minifier): Visit RHS while hoisting properties #9032

merged 6 commits into from
Jun 11, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 11, 2024

Description:

Handles

var FRUITS = { MANGO: "mango" }, getMangoLabel = (label) => label[FRUITS.MANGO];

while hoisting properties. In the code above, the initializer of the second variable declarator should be visited after hoisting the first variable declarator. Otherwise FRUITS.MANGO cannot be handled.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jun 11, 2024
@kdy1 kdy1 self-assigned this Jun 11, 2024
@kdy1 kdy1 requested a review from a team as a code owner June 11, 2024 06:21
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 11, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) June 11, 2024 06:21
kdy1
kdy1 commented Jun 11, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier
  • swc_ecma_usage_analyzer
  • swc_core

@kdy1 kdy1 disabled auto-merge June 11, 2024 06:22
@kdy1 kdy1 enabled auto-merge (squash) June 11, 2024 11:20
@kdy1 kdy1 disabled auto-merge June 11, 2024 11:20
@kdy1 kdy1 merged commit cb16994 into swc-project:main Jun 11, 2024
148 checks passed
@kdy1 kdy1 deleted the issue-9030 branch June 11, 2024 11:20
@kdy1 kdy1 mentioned this pull request Jun 12, 2024
Merged
kdy1 added a commit to kdy1/swc that referenced this pull request Jun 12, 2024
@kdy1
Revert "fix(es/minifier): Visit RHS while hoisting properties (swc-pr…
7b35eb3 
…oject#9032)"

This reverts commit cb16994.
kdy1 added a commit that referenced this pull request Jun 12, 2024
@kdy1
perf(es/minifier): Do not visit var init multiple times (#9039)
675916c 
**Description:**

I mistakenly introduced a performance regression with #9032. It makes the minifier visit the initializer of variables multiple times - once while normal visiting and once in `hoist_props_of_vars`. This PR fixes it.
@kdy1 kdy1 modified the milestones: Planned, v1.5.29 Jun 13, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Austaras Austaras Austaras approved these changes

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.29
Development

Successfully merging this pull request may close these issues.

minifer: Object reference breaking with switch case in minification
2 participants
@kdy1 @Austaras