perf(es/parser): Optimize lexing of template literals #9036
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
commented
Jun 11, 2024
sokra
reviewed
Jun 11, 2024
| raw.push(c); | ||
| raw_slice_start = self.cur_pos(); | ||
| } else { | ||
| self.bump(); | ||
|
|
||
| if let Ok(ref mut cooked) = cooked { | ||
| cooked.push(c); |
There was a problem hiding this comment.
Should cooked have the same optimization?
There was a problem hiding this comment.
I think so. I'll patch it tomorrow.
kdy1
added a commit
that referenced
this pull request
Jun 12, 2024
**Description:** Applies same trick as #9036, but for `cooked`
This was referenced Jun 12, 2024
kdy1
added a commit
to vercel/turborepo
that referenced
this pull request
Jun 13, 2024
### Description Update `swc_core` to `v0.93.4`. To apply swc-project/swc#9036 and swc-project/swc#9037. Those PR makes parsing of some files 5x faster. ### Testing Instructions See next.js counterpart: vercel/next.js#66781
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jun 13, 2024
### What? Update `swc_core` to `v0.93.4`. ### Why? To apply swc-project/swc#9036 and swc-project/swc#9037. Those PR makes parsing of some files 5x faster. ### How?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We don't need to push one char at a time.