Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(common): Make character analysis lazy #9696

Merged
merged 15 commits into from
Nov 1, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 31, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Oct 31, 2024
@kdy1 kdy1 self-assigned this Oct 31, 2024
Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: e1f4c33

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 mentioned this pull request Oct 31, 2024
@kdy1 kdy1 changed the title perf(common): Make new_source_file lazy perf(common): Make character analysis lazy Nov 1, 2024
@kdy1 kdy1 marked this pull request as ready for review November 1, 2024 05:22
@kdy1 kdy1 requested a review from a team as a code owner November 1, 2024 05:22
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 1, 2024
@kdy1 kdy1 enabled auto-merge (squash) November 1, 2024 05:23
@kdy1 kdy1 disabled auto-merge November 1, 2024 06:44
@kdy1 kdy1 merged commit 1c3eaf6 into swc-project:main Nov 1, 2024
147 of 152 checks passed
@kdy1 kdy1 deleted the common-lazy branch November 1, 2024 06:44
Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #9696 will degrade performances by 3.63%

Comparing kdy1:common-lazy (3a13ebc) with main (bcf05de)

Summary

⚡ 9 improvements
❌ 1 regressions
✅ 184 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:common-lazy Change
es/full/all/es2015 192.4 ms 183.2 ms +5%
es/full/all/es2016 190.7 ms 182 ms +4.77%
es/full/all/es2017 190.2 ms 181.2 ms +4.95%
es/full/all/es2018 188.5 ms 179.8 ms +4.84%
es/full/all/es2019 187.6 ms 178.9 ms +4.87%
es/full/all/es2020 180.9 ms 172 ms +5.2%
es/full/all/es3 256.5 ms 247.3 ms +3.71%
es/full/all/es5 250 ms 240.5 ms +3.94%
es/full/parser 1.5 ms 1.4 ms +9.1%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.63%

@kdy1 kdy1 modified the milestones: Planned, v1.8.0 Nov 4, 2024
kdy1 added a commit that referenced this pull request Nov 6, 2024
kdy1 added a commit to kdy1/swc that referenced this pull request Nov 11, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant