Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/plugin): Migrate swc plugin new to use .cargo/config.toml #9740

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

SpanishPear
Copy link
Contributor

@SpanishPear SpanishPear commented Nov 16, 2024

Description:
As per https://doc.rust-lang.org/cargo/reference/config.html we should be generating a .cargo/config.toml instead of .cargo/config when creating a new plugin

Motivation - console warnings 😆

BREAKING CHANGE:
Technically this means users must have a toolchain > 1.38 (released september, 2019 - so five years ago).
Given that:

  • the public documentation for swc plugins link directly to the latest version of the rust toolchain (currently 1.81)
  • 1.38 was > five years ago
  • This only impacts new usages of swc plugin new ..
  • README.md specifies that the swc-project/swc MSRV is 1.73 anyways - whilst that doesn't specifically refer to generated code, it shows the intent of the project :)

I don't believe it will have material impact.

I will raise a separate PR to generate the correct MSRV for both swc-project/swc and the generated plugin itself.

Related issue (if exists):

@SpanishPear SpanishPear requested a review from a team as a code owner November 16, 2024 06:54
Copy link

changeset-bot bot commented Nov 16, 2024

🦋 Changeset detected

Latest commit: 6129998

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SpanishPear SpanishPear changed the title Migrate to config.toml to fix warning Migrate plugin generated from swc plugin new to use .cargo/config.toml instead of .cargo/config to fix warning Nov 16, 2024
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #9740 will not alter performance

Comparing SpanishPear:patch-2 (6129998) with main (4ffb21e)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 added this to the Planned milestone Nov 18, 2024
kdy1
kdy1 previously approved these changes Nov 18, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 changed the title Migrate plugin generated from swc plugin new to use .cargo/config.toml instead of .cargo/config to fix warning fix(es/plugin): Migrate swc plugin new to use .cargo/config.toml Nov 18, 2024
@kdy1 kdy1 merged commit 4ffb21e into swc-project:main Nov 18, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants