Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visit): Derive serde for AstParentKind #9744

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 19, 2024

Description:

This is for turbopack.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Nov 19, 2024
@kdy1 kdy1 self-assigned this Nov 19, 2024
@kdy1 kdy1 requested review from a team as code owners November 19, 2024 08:40
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 19, 2024
Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 8d7acb3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 19, 2024
@kdy1 kdy1 enabled auto-merge (squash) November 19, 2024 08:44
@kdy1 kdy1 disabled auto-merge November 19, 2024 08:44
@kdy1 kdy1 enabled auto-merge (squash) November 19, 2024 08:44
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9744 will degrade performances by 3.1%

Comparing kdy1:visit-serde (8d7acb3) with main (14a5c1e)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:visit-serde Change
es/full/base/fixer 117.1 µs 120.9 µs -3.1%

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 20, 2024
@kdy1 kdy1 merged commit e0fdd68 into swc-project:main Nov 21, 2024
151 of 152 checks passed
@kdy1 kdy1 deleted the visit-serde branch November 21, 2024 11:42
@kdy1 kdy1 modified the milestones: Planned, 1.9.3 Nov 22, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant