Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Use raw value for emitting JSX text #9762

Merged
merged 3 commits into from
Nov 27, 2024
Merged

fix(es/codegen): Use raw value for emitting JSX text #9762

merged 3 commits into from
Nov 27, 2024
+29 −1

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7265b40

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9762 will improve performances by 4.28%

Comparing magic-akari:fix/issue-9758 (7265b40) with main (fa80a1e)

Summary

⚡ 1 improvements
✅ 193 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9758 Change
⚡ es/full/base/fixer 121.2 µs 116.2 µs +4.28%

@magic-akari magic-akari marked this pull request as ready for review November 26, 2024 14:50
@magic-akari magic-akari requested a review from a team as a code owner November 26, 2024 14:50
@kdy1 kdy1 added this to the Planned milestone Nov 27, 2024
@kdy1 kdy1 requested a review from a team as a code owner November 27, 2024 03:36
@kdy1 kdy1 changed the title fix(es/codegen): use raw value for emitting JSX text fix(es/codegen): Use raw value for emitting JSX text Nov 27, 2024
@kdy1 kdy1 merged commit b83c44f into swc-project:main Nov 27, 2024
21 of 22 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.10.0 Dec 2, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

@swc/core will turn > in jsx code into >, causing syntax errors
2 participants
@magic-akari @kdy1