Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/parser): Do not drop semicolon after using declarations #9815

Closed
wants to merge 1 commit into from

Conversation

@kdy1 kdy1 added this to the Planned milestone Dec 27, 2024
@kdy1 kdy1 requested a review from a team as a code owner December 27, 2024 09:17
Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 0edc661

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marco-ippolito
Copy link
Contributor

I would suggest adding a regression test 😺

Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #9815 will not alter performance

Comparing revert-9798-fix_do_not_parse_empty_stmt (0edc661) with main (7768114)

Summary

✅ 194 untouched benchmarks

@kdy1
Copy link
Member Author

kdy1 commented Dec 27, 2024

Hmm I think this PR is wrong.

@kdy1
Copy link
Member Author

kdy1 commented Dec 27, 2024

Closing in favor of #9816

@kdy1 kdy1 closed this Dec 27, 2024
@kdy1 kdy1 deleted the revert-9798-fix_do_not_parse_empty_stmt branch December 27, 2024 14:28
@kdy1 kdy1 modified the milestones: Planned, 1.10.4 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants