remove session summary data file updates #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xavluiz
commented
Mar 22, 2023
xavluiz
commented
- this removes the logic of updating the sessionSummary.json and will now use the global storage to save and retrieve the current day stats
xavluiz
requested review from
mmclead,
askdesigners,
pbstriker38 and
bjacobson26
xavluiz
commented
Mar 22, 2023
| @@ -10,15 +10,14 @@ export function setSessionStorageManager(storageManager: LocalStorageManager) { | |||
| storageMgr = storageManager; | |||
|
|
|||
| // convert old storage to new storage if needed | |||
| if (!storageMgr?.getValue('session_jwt')) { | |||
| if (!storageMgr?.getValue('session_converion_complete')) { | |||
There was a problem hiding this comment.
@pbstriker38 and I walked through installing his vscode with the previous version and with multiple windows, the following change will ensure the session.json data is transferred allowing non-focused windows to also transfer if the focused window isn't fast enough in setting the JWT
mmclead
approved these changes
Mar 23, 2023
good point. i'll update the version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.