-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor to ts, test against wider range of @typescript-eslint
#89
Conversation
This is really nice, thanks! |
Totally, I think it would definitely be ok to be a minor version. I think it's more like how we communicate to the users. |
@sweepline I think it should be good to go? Should I handle the merge and release? If so, can I have permission to the npm package (my id is |
@antfu Yeah it looks good. I invited you on npm. |
Observation: In its current state, the README seems to be missing the information on what version 4.0.x is intended for. 3.x.x and 4.1.x are covered, but not 4.0.x. |
As #82 (comment)
I am sorry for a rather big PR, but changes are interconnected and I thought it would be better to do them all together. Happy to explain if you have any doubts. These changes allow us to have more confidence when introducing changes, and help with long term maintainability.
This PR changes:
jest
tovitest
(as it has better TS and ESM support)@typescript-eslint
@typescript-eslint
(as logic-wise there is no requirements on the version)pnpm
(better handling for package alias)eslint-rule-composer
, as it seems to be unmaintained, and we don't use a lot from it. It's simpler to direct do that in-house.engines
field inpackage.json
. As our code is rather pure andeslint
itself would enforce the engines requirements already