Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @swelham,
I propose the following PR to allow
UeberauthMicrosoft
to be used with multi-tenant applications (where a single Microsoft config won't be sufficient; i.e. applications that let users to login via their own Microsoft accounts).It somehow relates to this comment here and this one here.
Basically what I'm doing is passing a bunch of options from the
conn
all the way down to theOauth.client/1
function. This way, I can do the following in my own app controller:You can see here that I select the proper Microsoft credentials based on some path params.
Let me know what you think. Happy to discuss a different approach.