Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let callers override prompt #65

Merged
merged 2 commits into from
Feb 20, 2023
Merged

let callers override prompt #65

merged 2 commits into from
Feb 20, 2023

Conversation

trashhalo
Copy link

We'd like to conditionally ask for consent depending on which flow they are going through our app.

@swelham
Copy link
Owner

swelham commented Feb 20, 2023

Hey @trashhalo, thanks for the PR.

I think you can now also remove the with_optional function as this is no longer used.

With that change, this looks good to merge.

@swelham swelham mentioned this pull request Feb 20, 2023
@swelham
Copy link
Owner

swelham commented Feb 20, 2023

Thanks for the quick updates 👍

@swelham swelham merged commit c12ec08 into swelham:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants