Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lc (locale) param in authorization URL #80

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

alejandrodevs
Copy link
Contributor

@alejandrodevs alejandrodevs commented Sep 25, 2023

In order to change the locale in the Microsoft IDP interface, the param lc has to be added in the authorization url.
List of supported locales: https://ss64.com/locale.html

Example URL:

https://login.microsoftonline.com/common/oauth2/v2.0/authorize?client_id=client_id&lc=10&prompt=&redirect_uri=http%3A%2F%2Fwww.example.com%2Fauth%2Fmicrosoft%2Fcallback&response_type=code&scope=https%3A%2F%2Fgraph.microsoft.com%2Fuser.read+openid+email+offline_access&state=4aLMsU9-69Hafb0QJ0AMCSQM

What do you think? @swelham

@alejandrodevs
Copy link
Contributor Author

This is similar to what has been done in this PR: ueberauth/ueberauth_google#102.

@alejandrodevs
Copy link
Contributor Author

@swelham Did you have the opportunity to take a look at this?

@swelham
Copy link
Owner

swelham commented Oct 2, 2023

Hey @alejandrodevs. Sorry, I haven't had chance to look at this yet. I will aim to take a look either today or tomorrow if that works?

@alejandrodevs
Copy link
Contributor Author

@swelham Sure, that works. My apologies if I sounded too insistent, it wasn't my intention. I just wanted to make sure this PR didn't go unnoticed.

@swelham
Copy link
Owner

swelham commented Oct 3, 2023

No worries, this looks good to me.

I will get it shipped.

@swelham swelham merged commit c4c6229 into swelham:master Oct 3, 2023
@swelham swelham changed the title Add support to lc param in authorization URL Add support for lc (locale) param in authorization URL Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants