Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #1

Merged
merged 88 commits into from
Nov 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
6abc254
[Doc] Fix on_train_batch_end description (#4330)
amogkam Oct 26, 2020
8e3faa2
get help from docstring (#4344)
louis-she Oct 26, 2020
48b6de0
update (#4343)
awaelchli Oct 27, 2020
c50c225
feature: Allow str arguments in Trainer.profiler (#3656)
ddrevicky Oct 27, 2020
6878f3b
Enable DDP Plugin to pass through args to LightningDistributedDataPar…
ananthsub Oct 27, 2020
4106e2f
Fix COMET_EXPERIMENT_KEY environment variable usage in comet logger …
Vozf Oct 27, 2020
5d10a36
Update __init__.py
williamFalcon Oct 27, 2020
00cc69a
Add "monitor" to saved ModelCheckpoints (#4383)
carmocca Oct 28, 2020
b26c71e
Add optimizer hooks in callbacks (#4379)
rohitgr7 Oct 28, 2020
4a095e1
[Docs] Warning on metric states (#4388)
SkafteNicki Oct 28, 2020
1e1a422
add option to log momentum (#4384)
jeremyjordan Oct 28, 2020
41de453
Add individuals to Metrics in CODEOWNERS (#4413)
teddykoker Oct 28, 2020
ff41d80
feat(wandb): log in sync with Trainer step (#4405)
borisdayma Oct 28, 2020
9cfd299
move example inputs to correct device when tracing module (#4360)
NumesSanguis Oct 29, 2020
ce261e4
Fix CSV logger warning (#4419)
carmocca Oct 29, 2020
b459fd2
fix: `nb` is set total number of devices, when nb is -1. (#4209)
ssaru Oct 29, 2020
bbd81df
Skips DDP parameter sync (#4301)
justusschock Oct 29, 2020
ebe3a31
[docs] distributed_backend -> accelerator (#4429)
Oct 29, 2020
d1234c5
deprecate passing ModelCheckpoint instance to Trainer(checkpoint_call…
awaelchli Oct 30, 2020
20a8eaa
fix ModelCheckpoint docs (#4426)
Oct 30, 2020
e0b856c
[Metrics] Confusion matrix class interface (#4348)
SkafteNicki Oct 30, 2020
48e0b33
[Changelog] 1.0.4 (#4440)
Oct 30, 2020
0f584fa
PyTorch 1.7 Stable support (#3821)
Oct 30, 2020
38bb4e2
[Metrics] Add multiclass auroc (#4236)
ddrevicky Oct 30, 2020
b50dd12
ReduceLROnPlateau doc fixed (#4459)
KevinMathewT Oct 31, 2020
1d594c5
[docker] Lock cuda version (#4453)
Oct 31, 2020
6211fd4
Fix type checker issue with explicit cast of ref_model object (#4457)
SeanNaren Oct 31, 2020
839813e
timeout for tpu check (#4340)
lezwon Nov 1, 2020
d537485
lock pytorch nightly version (#4469)
Nov 1, 2020
6ae4c6e
update docs on checkpoint_callback Trainer argument (#4461)
awaelchli Nov 2, 2020
169e8c3
Fix a typo in README (#4474)
lmxyy Nov 2, 2020
c2e72c3
[BUG-FIX] WandbLogger _sanitize_callable (#4422)
tchaton Nov 2, 2020
f40d086
Add manual logging to training_step manual optimization (#4476)
SeanNaren Nov 2, 2020
ef03c39
Add step index in checkpoint name (#3807)
Borda Nov 2, 2020
9b8102d
[DOC] Clarify `tpu_cores` training. (#4475)
tchaton Nov 2, 2020
102fa9e
[BUGFIX] AMP + Precision unscale grad (#4441)
tchaton Nov 2, 2020
66ade19
Rename conflicting test directories (#4451)
carmocca Nov 2, 2020
19187d3
[Metrics] Detach bugfix (#4313)
SkafteNicki Nov 2, 2020
ac3f739
[FEAT] logging refactors 1/n (#4439)
tchaton Nov 2, 2020
01ab2a9
[bug] [docs] Clearer optimizer_step override instructions (#4455)
ananyahjha93 Nov 2, 2020
958aa1a
[test] Accumulated gradient optimization tests (#4477)
tchaton Nov 2, 2020
ad2556b
Disable saving checkpoints if not trained (#4372)
rohitgr7 Nov 3, 2020
360b3d8
Disable training when limit_train_batches=0 (#4371)
rohitgr7 Nov 3, 2020
1396321
Add fsspec to tuner (#4458)
rohitgr7 Nov 3, 2020
9b7f016
Update old "module_arguments" and "hparams" references in docs (#4417)
awaelchli Nov 3, 2020
7b375ed
Add CheckpointConnector internal commentaries (#4421)
tarepan Nov 3, 2020
a32bffc
feature/ Add note about Argparse. (#4321)
tchaton Nov 3, 2020
ee414d2
Switch to PyTorch 1.6 in Drone CI (#4393)
Nov 3, 2020
5d08559
Avoid torchscript export for Metric forward (#4428)
ananthsub Nov 3, 2020
fc78ffa
extend release testing (#4506)
Borda Nov 4, 2020
db3cf2e
Update default filename (#4500)
rohitgr7 Nov 4, 2020
f79fb37
update contrib notes (#4514)
Borda Nov 4, 2020
0d1365c
release v1 (#4516)
Borda Nov 4, 2020
945d6f5
is_picklable: catch AttributeError (addresses #3771) (#4508)
jtamir Nov 4, 2020
11dc526
Bugfix/4449 dict attribute error (#4480)
tchaton Nov 4, 2020
41c6a13
update changelog after 1.0.5 (#4505)
Borda Nov 4, 2020
e81707b
[dockers] use inline cache (#4511)
Nov 4, 2020
51cc7a8
Horovod: fixed early stopping and added metrics aggregation (#3775)
tgaddair Nov 5, 2020
62ea461
update PR template (#4523)
Borda Nov 5, 2020
9c8701f
[feat] Logging refactor 2/n - train (#4495)
tchaton Nov 5, 2020
5e09fd3
show progressbar only on progress_rank 0 on ddp_slurm (#4437)
cool425589 Nov 6, 2020
f3dfb98
[ci] tag v1.4.1 for pypa/gh-action-pypi-publish (#4548)
Nov 6, 2020
6e5f232
Add Dali MNIST example (#3721)
irustandi Nov 6, 2020
854c136
add congratulations at the end of our notebooks (#4555)
tchaton Nov 7, 2020
bb356a7
added trainer api docs (#4569)
williamFalcon Nov 7, 2020
e0bdf81
updated trainer docs (#4570)
williamFalcon Nov 7, 2020
f63fec9
updated trainer docs (#4571)
williamFalcon Nov 7, 2020
09a5169
Adds shortcut for path to log (#4573)
williamFalcon Nov 8, 2020
0f64f15
ref: unify slurm and TE under backendPlugin 1/n (#4578)
williamFalcon Nov 8, 2020
bfaf014
ref: unify slurm and TE under backendPlugin 2/n (#4580)
williamFalcon Nov 8, 2020
624f5b5
ref: unify slurm and TE under backendPlugin 3/n (#4581)
williamFalcon Nov 8, 2020
3ba48d3
ref: unify slurm and TE under backendPlugin 5/n" (#4582)
williamFalcon Nov 8, 2020
ee35907
Accelerator docs (#4583)
williamFalcon Nov 8, 2020
01a925d
[Docs] Note on running metric in dp (#4494)
SkafteNicki Nov 9, 2020
e01190e
Adding pytorch-forecasting to community examples (#4575)
jdb78 Nov 9, 2020
45a6959
Fix docstring (#4585)
akihironitta Nov 9, 2020
4a6721a
Missing TorchScript trace's update (#4586)
NumesSanguis Nov 9, 2020
23719e3
[dockers] install nvidia-dali-cudaXXX (#4532)
Nov 9, 2020
41c9bee
Fix load disparity between normal and hpc (#4526)
tarepan Nov 9, 2020
4f3160b
Skip tuner algorithms on fast dev (#3903)
SkafteNicki Nov 9, 2020
465ec75
Metric ddp bugfix (#4482)
SkafteNicki Nov 10, 2020
30ad3e2
Replace a MisconfigurationException with warning in ModelCheckpoint c…
kazhang Nov 10, 2020
11415fa
[req] Set min version for skimage for tests (#4598)
s-rog Nov 10, 2020
470e294
fix logged keys in mlflow logger (#4412)
dscarmo Nov 10, 2020
343d19f
Find parameters which are specified in the LightningDataModule, only …
maxjeblick Nov 10, 2020
abf1d4b
fix mock pkgs in docs (#4591)
Borda Nov 10, 2020
7e08b0d
[bug-fix] DDP and automatic_optimization=False (#4485)
tchaton Nov 10, 2020
514cb22
[Fix] Move log value to cpu. (#4592)
tchaton Nov 10, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ name: torch-GPU

steps:
- name: testing
image: pytorchlightning/pytorch_lightning:base-cuda-py3.7-torch1.5
image: pytorchlightning/pytorch_lightning:base-cuda-py3.7-torch1.6

environment:
CODECOV_TOKEN:
Expand All @@ -32,6 +32,8 @@ steps:
- pip --version
- nvidia-smi
- pip install -r ./requirements/devel.txt --upgrade-strategy only-if-needed -v --no-cache-dir
# when Image has defined CUDa version we can switch to this package spec "nvidia-dali-cuda${CUDA_VERSION%%.*}0"
- pip install --extra-index-url https://developer.download.nvidia.com/compute/redist nvidia-dali-cuda100 --upgrade-strategy only-if-needed
- pip list
- coverage run --source pytorch_lightning -m pytest pytorch_lightning tests -v --color=yes --durations=25 # --flake8
- python -m pytest benchmarks pl_examples -v --color=yes --maxfail=2 --durations=0 # --flake8
Expand All @@ -46,6 +48,7 @@ steps:
trigger:
branch:
- master
- release/*
event:
include:
- push
Expand Down
9 changes: 6 additions & 3 deletions .github/BECOMING_A_CORE_CONTRIBUTOR.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ different fields contributing!
The first 5 core contributors will fit this profile. Thus if you overlap strongly with experiences and expertise as someone else on the team, you might have to wait until the next set of contributors are added.

#### Summary: Requirements to apply
- Solve 10 Github issues. The goal is to be inline with expectations for solving issues by the last one so you can do them on your own. If not, I might ask you to solve a few more specific ones.
- Do 10 PR reviews. The goal is to be inline with expectations for solving issues by the last one so you can do them on your own. If not, I might ask you to solve a few more specific ones.
The goal is to be inline with expectations for solving issues by the last one so you can do them on your own. If not, I might ask you to solve a few more specific ones.

If you want to be considered, ping me on gitter and start [tracking your progress here](https://docs.google.com/spreadsheets/d/15D58gp8DvI0Z6qbbYVRuaWioiwzafcP58-UlbuO_CMU/edit?usp=sharing).
- Solve 10+ Github issues.
- Create 5+ meaningful PRs which solves some reported issue - bug,
- Perform 10+ PR reviews from other contributors.

If you want to be considered, ping me on [Slack](https://join.slack.com/t/pytorch-lightning/shared_invite/zt-f6bl2l0l-JYMK3tbAgAmGRrlNr00f1A).
9 changes: 8 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,11 @@
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
* @williamfalcon @borda @teddykoker @awaelchli @nateraw @justusschock @tchaton @SeanNaren @ananyahjha93
* @williamfalcon @borda @teddykoker @awaelchli @nateraw @justusschock @tchaton @SeanNaren @ananyahjha93

# Metrics
/pytorch_lightning/metrics/* @teddykoker @ananyahjha93 @justusschock
/tests/metrics/* @teddykoker @ananyahjha93 @justusschock
/docs/source/metrics.rst @teddykoker @ananyahjha93 @justusschock


12 changes: 9 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
-->

Fixes # (issue)
Expand All @@ -20,10 +22,14 @@ Fixes # (issue)
<!-- For CHANGELOG separate each item in unreleased section by a blank line to reduce collisions -->

## PR review
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read [Review guidelines](https://github.com/PyTorchLightning/pytorch-lightning/wiki/Review-guidelines). In in short, see following bullet-list:

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from **Before submitting** are resolved
- [ ] Make sure the title is self explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; _Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases._


## Did you have fun?
Make sure you had fun coding 🙃
31 changes: 17 additions & 14 deletions .github/workflows/ci_dockers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: CI build Docker
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:
build-PL:
Expand All @@ -24,7 +24,7 @@ jobs:
# Set up Docker Buildx - to use cache-from and cache-to argument of buildx command
- uses: docker/setup-buildx-action@v1
- name: Build PL Docker
# publish master
# publish master/release
uses: docker/build-push-action@v2
with:
build-args: |
Expand All @@ -40,7 +40,7 @@ jobs:
fail-fast: false
matrix:
python_version: [3.7]
xla_version: [1.6] # todo: , "nightly"
xla_version: [1.6, "nightly"]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand All @@ -49,13 +49,13 @@ jobs:
# Set up Docker Buildx - to use cache-from and cache-to argument of buildx command
- uses: docker/setup-buildx-action@v1
- name: Build XLA Docker
# publish master
# publish master/release
uses: docker/build-push-action@v2
with:
build-args: |
PYTHON_VERSION=${{ matrix.python_version }}
XLA_VERSION=${{ matrix.xla_version }}
cache-from: pytorchlightning/pytorch_lightning:base-xla-cache-py${{ matrix.python_version }}-torch${{ matrix.xla_version }}
cache-from: pytorchlightning/pytorch_lightning:base-xla-py${{ matrix.python_version }}-torch${{ matrix.xla_version }}
file: dockers/base-xla/Dockerfile
push: false
timeout-minutes: 50
Expand All @@ -66,8 +66,8 @@ jobs:
fail-fast: false
matrix:
include:
#- python_version: 3.8
# pytorch_version: 1.7 # todo
- python_version: 3.8
pytorch_version: 1.7
- python_version: 3.7
pytorch_version: 1.6
- python_version: 3.6
Expand All @@ -86,14 +86,14 @@ jobs:
# Set up Docker Buildx - to use cache-from and cache-to argument of buildx command
- uses: docker/setup-buildx-action@v1
- name: Build CUDA Docker
# publish master
# publish master/release
uses: docker/build-push-action@v2
with:
build-args: |
PYTHON_VERSION=${{ matrix.python_version }}
PYTORCH_VERSION=${{ matrix.pytorch_version }}
CUDA_VERSION=${{ steps.extend.outputs.CUDA }}
cache-from: pytorchlightning/pytorch_lightning:base-cuda-cache-py${{ matrix.python_version }}-torch${{ matrix.pytorch_version }}
cache-from: pytorchlightning/pytorch_lightning:base-cuda-py${{ matrix.python_version }}-torch${{ matrix.pytorch_version }}
file: dockers/base-cuda/Dockerfile
push: false
timeout-minutes: 50
Expand All @@ -108,8 +108,11 @@ jobs:
pytorch_version: 1.6
- python_version: 3.6
pytorch_version: 1.4
#- python_version: 3.7
# pytorch_version: 1.8 # todo
- python_version: 3.7
pytorch_version: 1.7
# TODO
# - python_version: 3.7
# pytorch_version: 1.8
steps:
- name: Checkout
uses: actions/checkout@v2
Expand All @@ -126,15 +129,15 @@ jobs:
# Set up Docker Buildx - to use cache-from and cache-to argument of buildx command
- uses: docker/setup-buildx-action@v1
- name: Build CUDA Docker
# publish master
# publish master/release
uses: docker/build-push-action@v2
with:
build-args: |
PYTHON_VERSION=${{ matrix.python_version }}
PYTORCH_VERSION=${{ matrix.pytorch_version }}
PYTORCH_CHANNEL=${{ steps.extend.outputs.CHANNEL }}
CUDA_VERSION=${{ steps.extend.outputs.CUDA }}
cache-from: pytorchlightning/pytorch_lightning:base-conda-cache-py${{ matrix.python_version }}-torch${{ matrix.pytorch_version }}
cache-from: pytorchlightning/pytorch_lightning:base-conda-py${{ matrix.python_version }}-torch${{ matrix.pytorch_version }}
file: dockers/base-conda/Dockerfile
push: false
timeout-minutes: 50
6 changes: 3 additions & 3 deletions .github/workflows/ci_pkg-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: Install pkg
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:

Expand All @@ -20,7 +20,7 @@ jobs:
python-version: [3.6, 3.8]

steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci_test-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: CI base testing
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:
doctest:
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
coverage run --source pytorch_lightning -m pytest pytorch_lightning -v --color=yes --junitxml=junit/test-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml

- name: Upload pytest test results
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v2
with:
name: pytest-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}
path: junit/test-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci_test-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: PyTorch & Conda
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:
conda:
Expand All @@ -16,7 +16,7 @@ jobs:
matrix:
# os: [ubuntu-20.04]
python-version: [3.7]
pytorch-version: [1.3, 1.4, 1.5, 1.6] # , 1.7 # todo
pytorch-version: [1.3, 1.4, 1.5, 1.6, 1.7]

# Timeout: https://stackoverflow.com/a/59076067/4521646
timeout-minutes: 35
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
shell: bash -l {0}

- name: Upload pytest test results
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v2
with:
name: pytest-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}
path: junit/test-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci_test-full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: CI complete testing
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:
pytest:
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
run: |
# python -m pip install --upgrade --user pip
pip install --requirement requirements.txt --find-links https://download.pytorch.org/whl/cpu/torch_stable.html --quiet --upgrade
pip install --requirement ./requirements/devel.txt --quiet --upgrade
pip install --requirement ./requirements/devel.txt --find-links https://download.pytorch.org/whl/cpu/torch_stable.html --quiet --upgrade
python --version
pip --version
pip list
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
coverage run --source pytorch_lightning -m pytest pytorch_lightning tests pl_examples -v --color=yes --durations=0 --junitxml=junit/test-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml

- name: Upload pytest test results
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v2
with:
name: pytest-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}
path: junit/test-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_test-tpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: TPU tests

on:
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
# TODO: temporal disable TPU testing until we find way how to pass credentials to forked PRs
# pull_request:
# branches:
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
# pycobertura show coverage.xml

- name: Upload coverage results
uses: actions/upload-artifact@master
uses: actions/upload-artifact@v2
with:
name: coverage-TPU
path: coverage
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code-formatting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: "Check Code Format"

on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:
code-black:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docker-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish Docker Releases
# https://github.com/docker/build-push-action
on:
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
release:
types: [created]

Expand All @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
python_version: [3.6, 3.7, 3.8]
pytorch_version: [1.3, 1.4, 1.5, 1.6]
pytorch_version: [1.3, 1.4, 1.5, 1.6, 1.7]
exclude:
# excludes PT 1.3 as it is missing on pypi
- python_version: 3.8
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/docs-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ name: "Docs check"

on: # Trigger the workflow on push or pull request, but only for the master branch
push:
branches: [master]
branches: [master, "release/*"] # include release branches like release/1.0.x
pull_request:
branches: [master]
branches: [master, "release/*"]

jobs:
check-docs:
sphinx-check:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
Expand All @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.7
Expand All @@ -48,6 +48,7 @@ jobs:
# python -m pip install --upgrade --user pip
pip install --requirement requirements.txt --upgrade-strategy only-if-needed --find-links https://download.pytorch.org/whl/cpu/torch_stable.html --quiet
pip install --requirement requirements/extra.txt
pip install --requirement requirements/loggers.txt
pip install --requirement requirements/docs.txt
python --version
pip --version
Expand All @@ -68,7 +69,7 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.7
Expand Down
Loading