Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge dependabot PRs [DEVINFRA-285] #331

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Auto-merge dependabot PRs [DEVINFRA-285] #331

merged 1 commit into from
Jul 13, 2021

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 12, 2021

Requires a tokem with comment access to add the comment to Dependabot PRs, to be put into secret named REPO_COMMENT_TOKEN.

I've added an issue in the GitHub action about my slightly different way of invoking the action. jo-sm/at-dependabot-merge#1

Currently it fires whenever the "CI" workflow is successful, ignoring the Lint and Python workflows.
If this general approach is acceptable, the three workflows can be tied together either sequentially or concurrently with a new workflow that waits on them all.

Tested at jayvdb/jekyll-netlify#8

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jayvdb
Copy link
Contributor Author

jayvdb commented Jul 12, 2021

Note https://github.com/marketplace/actions/dependabot-auto-merge doesnt currently work due to ahmadnassri/action-dependabot-auto-merge#60

https://github.com/fastify/github-action-merge-dependabot should not have the same problem. It isnt clear whether those two will work with gitmodules updates , as they have config focused on choosing which PRs to merge based on semver.

@jayvdb jayvdb requested a review from silverjam July 12, 2021 15:15
@silverjam
Copy link
Contributor

Do I need to add a secret to this repo to enable this?

@jayvdb
Copy link
Contributor Author

jayvdb commented Jul 12, 2021

yes, a personal access token for an account which will do the commenting on PRs. Secret name in this PR is REPO_COMMENT_TOKEN, but I can change it if you prefer an alternative.

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secret is in place

@jayvdb jayvdb merged commit 48fb094 into master Jul 13, 2021
@jayvdb jayvdb deleted the auto-pr branch July 13, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants