do not force unwrap stdout #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert a change from #d2bd7f1aae1fc9455b208567ba5d85e42463c82c that caused the plugin to crash
fabianfett
reviewed
Oct 9, 2024
| @@ -32,7 +32,7 @@ struct Utils { | |||
|
|
|||
| let fd = dup(1) | |||
| let stdout = fdopen(fd, "rw") | |||
| defer { fclose(stdout!) } | |||
There was a problem hiding this comment.
we should change ci to use the released swift image here. I think the build issue happens with swift:6.0.0 and swift:6.0.1 but not 6.0-nightly.
There was a problem hiding this comment.
As much as I understand how it works in Swift-NIO, we can not give the container name as a parameter
https://github.com/apple/swift-nio/blob/main/.github/workflows/swift_6_language_mode.yml
That would be a change request for the Swift-NIO project
There was a problem hiding this comment.
The problem with ! is not in the CI, it crashes the plugin when using it. We can not force unwrap, there are cases where stdout is nil
fabianfett
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a change from #d2bd7f1aae1fc9455b208567ba5d85e42463c82c that caused the plugin to crash