Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Add Carthage support #17

Closed
wants to merge 6 commits into from
Closed

Conversation

Palleas
Copy link

@Palleas Palleas commented Nov 29, 2015

Hello,

I've added Carthage support for this project I started using. I know it says "Carthage compatible" but it
actually didn't provide a shared Framework scheme. This is the error you'd get if you tried using it:

$  carthage update
*** Fetching SwiftGif
*** Checking out SwiftGif at "v1.5.1"
*** xcodebuild output can be found in /var/folders/tk/cw93k7v928qf21kppt47d_380000gn/T/carthage-xcodebuild.QXYO0e.log
*** Skipped building SwiftGif due to the error:
Dependency "SwiftGif" has no shared framework schemes

If you believe this to be an error, please file an issue with the maintainers at https://github.com/bahlo/SwiftGif/issues/new

Here is what I've done:

  • Moved the code from "SwiftGifCommon" into a dedicated "SwiftGif" folder and created the framework scheme
  • Renamed the "SwiftGif" target into "SwiftGifDemo"
  • I updated the path in the podspec as well and bumped the version number so you can tag / push

Hopefully the travis build should still pass. Let me know what you think about this 😄

@bahlo
Copy link
Member

bahlo commented Nov 29, 2015

Thank you very much! I will look into this 👍

@Palleas
Copy link
Author

Palleas commented Nov 29, 2015

The Travis build is failing though, not sure why because I run the same command on my mac and it works 😢

@@ -4,5 +4,5 @@ osx_image: xcode7
script:
- xctool
-project SwiftGif.xcodeproj -scheme SwiftGif
-sdk iphonesimulator build test
-sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 6" build test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the line that is causing Travis to fail. When I run this command on my Mac, the tests still pass, but only after I get the following warning:

[Warning] Tried to install the test host app 'me.arne.SwiftGif' but failed. (3132 ms)
[Info] Preparing test environment failed; will retry 2 more times (0 ms)
[Info] Verified iOS Simulators... (0 ms)
[Info] Shut down iOS Simulator... (0 ms)
[Info] Stopped any existing iOS simulator jobs to get a fresh simulator. (364 ms)
[Info] Reset iOS simulator content and settings at path ...

Travis is failing at the same step: https://travis-ci.org/bahlo/SwiftGif/builds/93796224#L202

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have broken something when I moved target around. Didn't notice the warning, thought.
I'll have a look, thanks 😄

@bahlo
Copy link
Member

bahlo commented Nov 29, 2015

I also saw your tweet and I'm curious and happy to hear what kind of application you use this in (if you can disclose). ☺️

@Palleas
Copy link
Author

Palleas commented Dec 1, 2015

I'm using it to render Gif in an iOS extension, I'll put it on Github when it's done!

@bahlo bahlo mentioned this pull request Jan 28, 2016
@bahlo
Copy link
Member

bahlo commented Aug 22, 2016

Merged in v1.6-beta.1 (soon to be master) thank you so much 👍

@bahlo bahlo closed this Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants