This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
add UIImageView extension for GCD #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a little problem, a delay with no display when calculate the frames, maybe add the first frame as the placeholder is a good idea |
|
Thanks for the PR! I'll look into it in the next days 👍 |
|
What you said about adding the first frame is a good idea - would you mind adding that as well? |
|
Sorry, don't have time to do this now, I'm on my vacation, will work after the Chinese New Year. |
|
Alright, have a great vacation! 👌🌴 |
|
Merged in v1.6-beta.1 (soon to be master) awesome PR 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haven't test more, but I think this should improve the performance