This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Fix crash due to non-standard GIF in case of no value for kCGImagePro… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pertyGIFDictionary
|
Thank you very much, I'll review this later today and create a bugfix release 👍 |
|
I'm experiencing this issue as well in one of my apps. Might be worth merging! |
|
Merged in v1.6-beta.1 (soon to be master), thank you 😍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hot-fix for the issue "Crashes with invalid GIF data" (#18)
In case of non-standard GIF, which doesn't contains the value for "kCGImagePropertyGIFDictionary" in its metadata, the app crashes.
To handle this case, I added the logic to check an existence of the value, and if not, return default delay, which is 0.1.
I also added "non_standard_gif.gif" file to the project for testing.
Sample non-standard gif file is from http://media4.giphy.com/media/CsyFeRxyH0um4/200w.gif.