Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wdocumentation warning. NFCI. #213

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Fix -Wdocumentation warning. NFCI. #213

merged 1 commit into from
Nov 6, 2019

Conversation

JDevlieghere
Copy link

llvm-svn: 372418
(cherry picked from commit 60a6f31)

llvm-svn: 372418
(cherry picked from commit 60a6f31)
@JDevlieghere
Copy link
Author

@swift-ci please test

@cyndyishida
Copy link

cyndyishida commented Nov 6, 2019

Since the update-checkout script doesn't call this dated branch anywhere, how do you check if the PR test failure is because of a dirty baseline, check that swift/master is a reflection and check those CI jobs?

@JDevlieghere
Copy link
Author

JDevlieghere commented Nov 6, 2019

I don't think PR testing is using update-checkout at all. @shahmishal knows the details.

The linux failure is definitely because of a dirty baseline, which is why Linux testing in temporarily not required. When that's fixed you should always (in theory) be able to rely on a clean baseline. However, in practice, flakiness or configuration errors mean that it is possible to end up with a dirty baseline. When I'm suspicious I usually check a few subsequent PR-test runs and see if there's a pattern.

@shahmishal
Copy link
Member

I don't think PR testing is using update-checkout at all. @shahmishal knows the details.

The linux failure is definitely because of a dirty baseline, which is why Linux testing in temporarily not required. When that's fixed you should always (in theory) be able to rely on a clean baseline. However, in practice, flakiness or configuration errors mean that it is possible to end up with a dirty baseline. When I'm suspicious I usually check a few subsequent PR-test runs and see if there's a pattern.

it's not using update-checkout because for apple/* branches don't get tested for swift changes.

Job it self is checking out the PR branch git rev-parse refs/remotes/origin/origin/pr/213/merge^{commit} # timeout=10

@shahmishal
Copy link
Member

#1 (comment) I was seeing this failure yesterday when I created Linux PR testing for LLVM Project. (cc: @hyp)

@shahmishal
Copy link
Member

@swift-ci clean test Linux

@JDevlieghere JDevlieghere merged commit b14d553 into swiftlang:apple/stable/20190619 Nov 6, 2019
@JDevlieghere JDevlieghere deleted the cherrypick/r372418 branch November 6, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants