[lldb] Rewrite Swift REPL completion to use CompletionRequest #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all the workaround and problematic code that was needed for the old interface. With the CompletionRequest we no longer need to calculate the common prefix ourselves and we don't need to calculate the magic return value. On the other hand we can no longer provide 'appendix' completions (E.g. completing "Suff" with "ix", instead we now need to provide the completion "Suffix"), so in one case we now need to prefix the completion with the existing prefix from the CompletionRequest (as Swift only returns the string to append and not the whole token). Also rewrites the TestSwiftREPLCompletion.py to test all the problematic cases and some more. Fixes rdar://problem/58854651
dcci
approved these changes
Jan 28, 2020
|
The non-swift changes are in #678 (which first need to be merged to get this running). |
|
@swift-ci test |
|
This already landed via the automerger as 1eaa5da (as this was required to get the branch building). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the workaround and problematic code that was needed
for the old interface. With the CompletionRequest we no longer need
to calculate the common prefix ourselves and we don't need to calculate
the magic return value. On the other hand we can no longer provide
'appendix' completions (E.g. completing "Suff" with "ix", instead
we now need to provide the completion "Suffix"), so in one case
we now need to prefix the completion with the existing prefix from
the CompletionRequest (as Swift only returns the string to append
and not the whole token).
Also rewrites the TestSwiftREPLCompletion.py to test all the
problematic cases and some more.