Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count all the frames just to skip the current inlined ones. (#8… #8301

Merged
merged 1 commit into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. Don't count all the frames just to skip the current inlined ones. (ll…

    …vm#80918)
    
    The algorithm to find the DW_OP_entry_value requires you to find the
    nearest non-inlined frame. It did that by counting the number of stack
    frames so that it could use that as a loop stopper.
    
    That is unnecessary and inefficient. Unnecessary because GetFrameAtIndex
    will return a null frame when you step past the oldest frame, so you
    already have the "got to the end" signal without counting all the stack
    frames.
    And counting all the stack frames can be expensive.
    
    (cherry picked from commit a04c636)
    jimingham committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2aef748 View commit details
    Browse the repository at this point in the history