🍒[release/6.0][llvm][MachO] Fix integer truncation in rebase/bind parsing (#89337) #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Count` and `Skip` should use `uint64_t` as they are encoded/decoded using 64-bit ULEB128. In `*_OPCODE_DO_*_ULEB_TIMES_SKIPPING_ULEB`, `Skip` could be encoded as a two's complement for moving `SegmentOffset` backwards. Having a 32-bit `Skip` truncates the encoded value and leads to a malformed `AdvanceAmount` and invalid `SegmentOffset` that extends past valid sections. (cherry picked from commit b910beb)
|
@swift-ci please test |
|
Hi @fredriss could you help merge this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CountandSkipshould useuint64_tas they are encoded/decoded using 64-bit ULEB128.In
*_OPCODE_DO_*_ULEB_TIMES_SKIPPING_ULEB,Skipcould be encoded as a two's complement for movingSegmentOffsetbackwards. Having a 32-bitSkiptruncates the encoded value and leads to a malformedAdvanceAmountand invalid
SegmentOffsetthat extends past valid sections.(cherry picked from commit b910beb)