Skip to content

Commit

Permalink
Fix InlayHintTests
Browse files Browse the repository at this point in the history
We need to include text edits in the expected inlay hints.
  • Loading branch information
fwcd committed May 24, 2022
1 parent 8c2beb5 commit 670a696
Showing 1 changed file with 24 additions and 13 deletions.
37 changes: 24 additions & 13 deletions Tests/SourceKitLSPTests/InlayHintTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@ final class InlayHintTests: XCTestCase {
}
}

private func makeInlayHint(position: Position, kind: InlayHintKind, label: String) -> InlayHint {
InlayHint(
position: position,
kind: kind,
label: .string(label),
textEdits: [
TextEdit(range: position..<position, newText: label)
]
)
}

func testEmpty() throws {
let text = ""
let hints = try performInlayHintRequest(text: text)
Expand All @@ -74,12 +85,12 @@ final class InlayHintTests: XCTestCase {
"""
let hints = try performInlayHintRequest(text: text)
XCTAssertEqual(hints, [
InlayHint(
makeInlayHint(
position: Position(line: 0, utf16index: 5),
kind: .type,
label: ": Int"
),
InlayHint(
makeInlayHint(
position: Position(line: 1, utf16index: 5),
kind: .type,
label: ": String"
Expand All @@ -103,12 +114,12 @@ final class InlayHintTests: XCTestCase {
let range = Position(line: 6, utf16index: 0)..<Position(line: 9, utf16index: 0)
let hints = try performInlayHintRequest(text: text, range: range)
XCTAssertEqual(hints, [
InlayHint(
makeInlayHint(
position: Position(line: 6, utf16index: 10),
kind: .type,
label: ": Bool"
),
InlayHint(
makeInlayHint(
position: Position(line: 7, utf16index: 12),
kind: .type,
label: ": Int"
Expand All @@ -134,27 +145,27 @@ final class InlayHintTests: XCTestCase {
"""
let hints = try performInlayHintRequest(text: text)
XCTAssertEqual(hints, [
InlayHint(
makeInlayHint(
position: Position(line: 1, utf16index: 20),
kind: .type,
label: ": Int"
),
InlayHint(
makeInlayHint(
position: Position(line: 2, utf16index: 25),
kind: .type,
label: ": String"
),
InlayHint(
makeInlayHint(
position: Position(line: 6, utf16index: 20),
kind: .type,
label: ": String"
),
InlayHint(
makeInlayHint(
position: Position(line: 7, utf16index: 25),
kind: .type,
label: ": Int"
),
InlayHint(
makeInlayHint(
position: Position(line: 11, utf16index: 25),
kind: .type,
label: ": Double"
Expand Down Expand Up @@ -186,22 +197,22 @@ final class InlayHintTests: XCTestCase {
"""
let hints = try performInlayHintRequest(text: text)
XCTAssertEqual(hints, [
InlayHint(
makeInlayHint(
position: Position(line: 2, utf16index: 5),
kind: .type,
label: ": (Int) -> ()"
),
InlayHint(
makeInlayHint(
position: Position(line: 3, utf16index: 31),
kind: .type,
label: ": String"
),
InlayHint(
makeInlayHint(
position: Position(line: 4, utf16index: 40),
kind: .type,
label: ": Double"
),
InlayHint(
makeInlayHint(
position: Position(line: 4, utf16index: 43),
kind: .type,
label: ": Double"
Expand Down

0 comments on commit 670a696

Please sign in to comment.