build: add the ability to pass in SwiftCollections #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building against SwiftCollections from a build tree when building with SwiftPM from a build tree.
|
CC: @tomerd |
|
@swift-ci please test |
|
seems fine to me |
benlangmuir
approved these changes
Jul 21, 2021
|
we are likely to rollback the SwiftPM change, but lets keep this open when we are ready to roll forward again cc @neonichu |
neonichu
approved these changes
Jul 21, 2021
|
I think that we should merge this we are holding off on swiftlang/swift-package-manager#3628 (CC: @tomerd) |
|
@compnerd to confirm my cmake understanding: this will not cause any errors if collections is not found and is not needed (due to |
|
@benlangmuir precisely - this allows us to build SK-LSP with and without a build tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building against SwiftCollections from a build tree when
building with SwiftPM from a build tree.