Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package.swift: bump swift-tools-version and OS requirement #729

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Package.swift: bump swift-tools-version and OS requirement #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version:5.5
// swift-tools-version:5.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny that this even worked

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate? Why wouldn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated SwiftPM to 5.7 a while ago, so I think the expected behavior would have been that SourceKit-LSP started failing back then.


import PackageDescription
import Foundation
Expand All @@ -14,7 +14,7 @@ if ProcessInfo.processInfo.environment["SOURCEKIT_LSP_CI_INSTALL"] != nil {

let package = Package(
name: "SourceKitLSP",
platforms: [.macOS("10.15.4")],
platforms: [.macOS("12.0")],
products: [
.executable(
name: "sourcekit-lsp",
Expand Down