Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolchainRegistryTests: avoid identity checks for localFileSystem #733

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Apr 19, 2023

We'd like to remove AnyObject requirement from FileSystem in swiftlang/swift-tools-support-core#410, which will make identity checks on any FileSystem impossible. These checks were an anti-pattern anyway, especially in tests, which should be flexible enough to support an arbitrary file system implementation. If certain behavior is not available on FileSystem we should modify that protocol instead.

We'd like to remove `AnyObject` requirement from `FileSystem`, which will make identity checks on `any FileSystem` impossible. These checks were an anti-pattern anyway, especially in tests, which should be flexible enough to support an arbitrary file system implementation. If certain behavior is not available on `FileSystem` we should modify that protocol instead.
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov changed the title ToolchainRegistryTests: don't do identity check for localFileSystem ToolchainRegistryTests: avoid identity checks for localFileSystem Apr 19, 2023
@MaxDesiatov MaxDesiatov merged commit 781d69f into main Apr 20, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fs-id-check-is-bad branch April 20, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants