Code review feedback: move assertion for better locality with the pot…

…ential bug.
swiftlang · Aug 22, 2024 · 4bda3c1 · 4bda3c1
1 parent 4f58040
commit 4bda3c1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Sources/SwiftDocCPluginUtilities/ParsedArguments.swift b/Sources/SwiftDocCPluginUtilities/ParsedArguments.swift
@@ -23,6 +23,8 @@ struct ParsedArguments {
         pluginArguments      = .init(extractingFrom: &arguments)
         symbolGraphArguments = .init(extractingFrom: &arguments)
 
+        assert(arguments.extractOption(named: DocCArguments.outputPath).isEmpty,
+               "There shouldn't be any output path argument left in the remaining DocC arguments.")
         self.arguments = arguments
     }
 
@@ -108,8 +110,6 @@ struct ParsedArguments {
         arguments.insertIfMissing(.option(DocCArguments.fallbackBundleIdentifier, value: targetName))
 
         arguments.insertIfMissing(.option(DocCArguments.additionalSymbolGraphDirectory, value: symbolGraphDirectoryPath))
-
-        assert(arguments.extractOption(named: DocCArguments.outputPath).isEmpty,"The plugin arguments should have extracted the output path.")
         arguments.insertIfMissing(.option(DocCArguments.outputPath, value: outputPath))
 
         if pluginArguments.enableCombinedDocumentation {