Remove deprecated usages of 'layout' API of 'ContentAndMedia' in docs #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Can someone help me? This PR is ready to merge, should I mention some member to review? |
| @@ -49,7 +49,7 @@ class ExternalLinkableTests: XCTestCase { | |||
| } | |||
|
|
|||
| @Section(title: "Create a New AR Project 💻") { | |||
| @ContentAndMedia(layout: vertical) { | |||
| @ContentAndMedia { | |||
There was a problem hiding this comment.
Can we leave this test unchanged for now? Otherwise this PR looks good to go. Thank you!
Suggested change
| @ContentAndMedia { | |
| @ContentAndMedia(layout: vertical) { |
There was a problem hiding this comment.
It's ok, I've discard it. But I'm not sure why shouldn't we chsnge it now
|
@swift-ci please test |
|
@swift-ci please test |
ethan-kusters
approved these changes
Apr 19, 2023
|
Thank you @Saafo! I'll go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: None.
Summary
Provide a description of what your PR addresses, explaining the expected user experience.
Also, provide an overview of your implementation.
Since 'layout' init parameter of 'ContentAndMedia' is deprecated by https://github.com/apple/swift-docc/blob/f7cc54ab64eeebe06d4ca721cc7ac78c2da6f545/Sources/SwiftDocC/Semantics/ContentAndMedia.swift#L86
We should remove the usages of this parameter in our documents and tests
Dependencies
Describe any dependencies this PR might have, such as an associated branch in another repository.
None.
Testing
Describe how a reviewer can test the functionality of your PR. Provide test content to test with if
applicable.
Steps:
None.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded