False positive warning when curating symbol with special character #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@swift-ci please test |
QuietMisdreavus
approved these changes
Jun 23, 2023
d-ronnqvist
added a commit
to d-ronnqvist/swift-docc
that referenced
this pull request
Jun 24, 2023
…wiftlang#642) * Fix false-positive warning for curated symbols with special characters rdar://111227479 * Remove redundant symbol index modification
d-ronnqvist
added a commit
that referenced
this pull request
Jun 26, 2023
) (#644) * Fix false-positive warning for curated symbols with special characters rdar://111227479 * Remove redundant symbol index modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: #640 (rdar://111227479)
Summary
This fixes a false positive warning when a symbol with characters that aren't allowed in a resolved reference URL is curated. The warning happened because 2nd pass curation visited the link again before it was added to the referenceIndex.
Dependencies
None
Testing
Build documentation for the MeshGenerator project, as described in this issue #640
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded