-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency #1414
Merged
Merged
Add missing dependency #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
artemcm
approved these changes
Aug 14, 2023
owenv
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency needs to be added around line 144 so it can be properly handled in local-deps mode
@swift-ci please test |
@swift-ci please test windows |
owenv
approved these changes
Aug 14, 2023
finagolfin
added a commit
to finagolfin/swift-driver
that referenced
this pull request
Nov 10, 2023
The llbuild executable is not a dependency of this library.
finagolfin
added a commit
to finagolfin/swift-driver
that referenced
this pull request
Nov 12, 2023
The llbuild executable is not a dependency of this library.
compnerd
pushed a commit
that referenced
this pull request
Dec 2, 2023
The llbuild executable is not a dependency of this library.
nkcsgexi
added a commit
that referenced
this pull request
Jun 4, 2024
[5.10] Revert 'Add missing dependency (#1414)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.