Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency #1414

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add missing dependency #1414

merged 1 commit into from
Aug 14, 2023

Conversation

neonichu
Copy link
Contributor

No description provided.

@neonichu neonichu requested a review from artemcm August 14, 2023 18:19
@neonichu
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency needs to be added around line 144 so it can be properly handled in local-deps mode

@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test windows

@neonichu neonichu merged commit 41f491d into swiftlang:main Aug 14, 2023
@neonichu neonichu deleted the fix-deps branch August 14, 2023 23:27
finagolfin added a commit to finagolfin/swift-driver that referenced this pull request Nov 10, 2023
The llbuild executable is not a dependency of this library.
finagolfin added a commit to finagolfin/swift-driver that referenced this pull request Nov 12, 2023
The llbuild executable is not a dependency of this library.
compnerd pushed a commit that referenced this pull request Dec 2, 2023
The llbuild executable is not a dependency of this library.
nkcsgexi added a commit that referenced this pull request Jun 4, 2024
[5.10] Revert 'Add missing dependency (#1414)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants