Add the UseExplicitNilCheckInConditions rule.
#627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule diagnoses and replaces occurrences of patterns like `if let _ = x` with `if x != nil` (likewise for conditions in `guard` and `while` statements). The rationale for this is that explicitly testing for `nil` is clearer about intent than binding and immediately discarding the wrapped value.
|
cc @dylansturg |
dylansturg
approved these changes
Sep 15, 2023
| Static properties of a type that return that type should not include a reference to their type. | ||
|
|
||
| Lint: Non-literal empty array initialization will yield a lint error. | ||
| Format: All invalid use sites would be related with empty literal (with or without explicit type annotation). |
There was a problem hiding this comment.
"would be replaced with empty literal..."?
There was a problem hiding this comment.
Ah, that's a typo from earlier, there was a race between the generate-the-docs PR and the one adding this rule so it didn't get generated the first time. I'll update that in a separate follow-up because I need to do a pass over all the rule docs anyway to make sure they're formatted nicely in the new Markdown file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule diagnoses and replaces occurrences of patterns like
if let _ = xwithif x != nil(likewise for conditions inguardandwhilestatements). The rationale for this is that explicitly testing fornilis clearer about intent than binding and immediately discarding the wrapped value.