[OrderedImports] Fix dropped trailing comments on top-level code items. #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some validation logic in format rule tests. We already run the pretty printer afterwards to verify that there aren't any invariants broken that would cause an assertion failure, but we don't compare the actual pretty-printed text to the originally transformed tree (because we don't want the output of those tests to be sensitive to pretty-printer configuration). What we *can* do, which is still an improvement, is walk the token sequence and compare the tokens and trivia in a whitespace-insensitive manner. This makes sure that we don't move trivia around in a way that the format rule would accept but that the pretty-printer wouldn't know how to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some validation logic in format rule tests. We already run the pretty printer afterwards to verify that there aren't any invariants broken that would cause an assertion failure, but we don't compare the actual pretty-printed text to the originally transformed tree (because we don't want the output of those tests to be sensitive to pretty-printer configuration). What we can do, which is still an improvement, is walk the token sequence and compare the tokens and trivia in a whitespace-insensitive manner. This makes sure that we don't move trivia around in a way that the format rule would accept but that the pretty-printer wouldn't know how to handle.