-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.10] Add fixes that were present in 509.0.0 but not release/5.10 #704
Merged
ahoppen
merged 19 commits into
swiftlang:release/5.10
from
ahoppen:ahoppen/5.10/cherry-picks
Mar 19, 2024
Merged
[5.10] Add fixes that were present in 509.0.0 but not release/5.10 #704
ahoppen
merged 19 commits into
swiftlang:release/5.10
from
ahoppen:ahoppen/5.10/cherry-picks
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the configuration options to allow disabling the addtion of trailing commas on multi-line collections.
…literal rather than initializer
…iteral array init Instead of using an archaic initializer call syntax, let's replace it with an empty array literal with a type annotation (if there isn't one).
…UseLiteralForEmptyCollectionInit`
…er with default values
…doesn't affect other cases
Like with `some/any` type sugar, when we simplify an `Optional` whose type parameter is an attributed type, we need to wrap it in parentheses so that the `?` doesn't bind with the contained type. Fixes swiftlang#657.
✅ Cross-repo testing from swiftlang/swift-syntax#2201 passed. |
allevato
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
airspeedswift
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release/5.10
branch. A couple other high-priority fixes were only merged intomain
but not intorelease/5.10
even though they were intended to be part of the 5.10 release. These PRs arerelease/5.10
[<Type>]()
into literal … #617@available
attributes. #656@available
attributesOptional< @Sendable (Int) -> (Float)>
to@Sendable (Int) -> (Float)?
which has a different semantic meaning@available
attributes and types prefixed with an attribute, respectively