Simplify DispatchGroup/DispatchSemaphore usage

swiftlang · Jan 13, 2022 · 97ccc8d · 97ccc8d
1 parent 8d4b724
commit 97ccc8d
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/Sources/Workspace/Workspace.swift b/Sources/Workspace/Workspace.swift
@@ -2275,17 +2275,14 @@ extension Workspace {
 
         // finally download zip files, if any
         for artifact in (zipArtifacts.map{ $0 }) {
-            semaphore.wait()
-            group.enter()
-            defer { group.leave() }
-
             let parentDirectory =  self.location.artifactsDirectory.appending(component: artifact.packageRef.identity.description)
             guard observabilityScope.trap ({ try fileSystem.createDirectory(parentDirectory, recursive: true) }) else {
                 continue
             }
 
             let archivePath = parentDirectory.appending(component: artifact.url.lastPathComponent)
 
+            semaphore.wait()
             group.enter()
             var headers = HTTPClientHeaders()
             headers.add(name: "Accept", value: "application/octet-stream")