-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-9133] JUnit output format doesn't work if --parallel not selected #4752
Comments
Comment by Arjun Nayini (JIRA) @aciidb0mb3r - I picked up this ticket and started on it. I found that the `TestRunner` and `ParallelTestRunner` are actually separate `final class` types that aren't tied together by anything. I was thinking I could get this done but would want to refactor those types to adhere to a single protocol (refactor them to look alike) and then add in xunit output for the serial one. Currently it looks like the xunit generator class is just explicitly tied to the parallel test runner. Does this seem like a reasonable approach here? Figured I would ping you since you have the latest commits in that area of the code. |
Comment by Arjun Nayini (JIRA) Actually I need to think about this a bit more. Seems like perhaps a SerialTestRunner type might make things a bit more clear with both ParallelTestRunner and SerialTestRunner encapsulating some set of TestRunners. |
Any news on this? |
It would be nice if this feature/option ( |
Bump for this issue. We're about to enter 2024, would be great to get something as foundational as this fixed. Note, this kind of report is very important for CI and observability integrations. |
Tracked internally as rdar://129450002. (I'm pretty sure it's tracked with an older radar number too, but I can't find it right now.) |
Also, why is the option labeled xunit? It looks like this format is actually based on junit (from Java), while xunit appears to be something that's part of the .NET ecosystem. |
There is an xUnit.net project that is for the .NET ecosystem, but xunit has also been used to refer to a family of testing frameworks (the idea being that the x refers to the language). See Wikipedia. |
The naming of the flag predates me joining the team. For what it's worth, swift-testing does call it JUnit internally. 🤷🏻♂️ |
Additional Detail from JIRA
md5: 7a7f61fc246593e1da18eec9acf288a5
Issue Description:
The JUnit output report should be printed regardless of the setting of --parallel.
Running:
swift test --xunit-output=/tmp/results.xml
doesn't generate a file at /tmp/results.xml.
Running:
swift test --xunit-output=/tmp/results.xml --parallel --num-workers=1
does generate a file at /tmp/results.xml
The text was updated successfully, but these errors were encountered: