Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift-testing does not build with ToT SwiftPM #7479

Closed
grynspan opened this issue Apr 22, 2024 · 4 comments · Fixed by #7493
Closed

swift-testing does not build with ToT SwiftPM #7479

grynspan opened this issue Apr 22, 2024 · 4 comments · Fixed by #7493
Labels
bug swift test Changes impacting `swift test` tool

Comments

@grynspan
Copy link
Contributor

A recent Swift Package Manager change seems to have regressed swift-testing:

https://ci.swift.org/job/pr-swift-testing-macos/633/
@grynspan grynspan added bug swift test Changes impacting `swift test` tool labels Apr 22, 2024
@grynspan grynspan mentioned this issue Apr 22, 2024
Merged
2 tasks
@finagolfin
Copy link
Member

The new swift-foundation does not build either since the April 21 trunk snapshot of the linux toolchain:

> ../swift-DEVELOPMENT-SNAPSHOT-2024-04-21-a-ubi9/usr/bin/swift build
error: InternalError(description: "Internal error. Please file a bug at https://github.com/apple/swift-package-manager/issues with this info. unknown target <ResolvedModule: FoundationInternationalizationTests, test, tools>")

The prior April 13 trunk snapshot works fine.

@MaxDesiatov, maybe you know what's going on here.

@grynspan
Copy link
Contributor Author

We're now seeing it on Linux too. https://ci.swift.org/job/pr-swift-testing-linux-5.10/683/console

@stmontgomery
Copy link
Contributor

Our current suspicion is that this may have been caused by #7353

@stmontgomery stmontgomery mentioned this issue Apr 23, 2024
Merged
2 tasks
@finagolfin
Copy link
Member

I can confirm that reverting #7353 again gets swift-foundation building on linux with the latest April 22 trunk snapshot of the toolchain.

MaxDesiatov added a commit that referenced this issue Apr 24, 2024
@MaxDesiatov
Include host triple targets in ResolvedPackage
2afeca4 
Modified `ResolvedModule` build triples were not reflected in `ResolvedPackage`, which meant those modules aren't included in the build graph.

Verified with `swift-foundation` and `swift-testing` packages.

Resolves #7479.
@MaxDesiatov MaxDesiatov mentioned this issue Apr 24, 2024
Merged
MaxDesiatov added a commit that referenced this issue Apr 24, 2024
@MaxDesiatov
Include host triple test modules in ResolvedPackage (#7493)
b9eb3c1 
Modified `ResolvedModule` build triples were not reflected in
`ResolvedPackage`, which excluded those modules from the build graph.

Verified manually with `swift-foundation` and `swift-testing` packages.
More comprehensive automated tests will be included in a future PR.

Resolves #7479.
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this issue May 15, 2024
@MaxDesiatov @furby-tm
Include host triple test modules in ResolvedPackage (swiftlang#7493)
b191fad 
Modified `ResolvedModule` build triples were not reflected in
`ResolvedPackage`, which excluded those modules from the build graph.

Verified manually with `swift-foundation` and `swift-testing` packages.
More comprehensive automated tests will be included in a future PR.

Resolves swiftlang#7479.
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this issue May 15, 2024
@MaxDesiatov @furby-tm
Include host triple test modules in ResolvedPackage (swiftlang#7493)
61eb171 
Modified `ResolvedModule` build triples were not reflected in
`ResolvedPackage`, which excluded those modules from the build graph.

Verified manually with `swift-foundation` and `swift-testing` packages.
More comprehensive automated tests will be included in a future PR.

Resolves swiftlang#7479.
MaxDesiatov added a commit that referenced this issue Jun 6, 2024
@MaxDesiatov
Include host triple test modules in ResolvedPackage (#7493)
59f1edd 
Modified `ResolvedModule` build triples were not reflected in
`ResolvedPackage`, which excluded those modules from the build graph.

Verified manually with `swift-foundation` and `swift-testing` packages.
More comprehensive automated tests will be included in a future PR.

Resolves #7479.

(cherry picked from commit b9eb3c1)

# Conflicts:
#	Sources/PackageGraph/ModulesGraph+Loading.swift
#	Sources/PackageGraph/Resolution/ResolvedPackage.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug swift test Changes impacting `swift test` tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include host triple test modules in ResolvedPackage swiftlang/swift-package-manager
3 participants
@stmontgomery @grynspan @finagolfin