Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS self-hosted pipeline to the nightly toolchain #8137

Closed
1 task done
bkhouri opened this issue Nov 22, 2024 · 2 comments
Closed
1 task done

Update macOS self-hosted pipeline to the nightly toolchain #8137

bkhouri opened this issue Nov 22, 2024 · 2 comments
Labels
bug continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines

Comments

@bkhouri
Copy link
Contributor

bkhouri commented Nov 22, 2024

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

The macOS self-hosted pipeline is running Swift 5.9.2. This prevents the use of Swift Testing, and is currently blocking, at a minimum, the following PRs (which are currently marked as draft pending resolution if this issue):

It would be ideal to update the macOS self-hosted pipeline toolchain version such that it uses the same version across all pipelines.

Expected behavior

A toolchain version that supports Swift Testing is in use by all pipelines.

Accessing the last successful build will show Swift 6.x in use.
https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/lastSuccessfulBuild/execution/node/43/log/

Actual behavior

The self-hosted macOS pipeline is still using 5.9.2.

https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/4562/execution/node/43/log/

Steps to reproduce

Open the last successful build

https://ci.swift.org/job/swift-package-manager-with-xcode-self-hosted-PR-osx/lastSuccessfulBuild/execution/node/43/log/

Swift Package Manager version/commit hash

N/A

Swift & OS version (output of swift --version ; uname -a)

N/A

@shahmishal
Copy link
Member

Created a new pull request job to support nightly toolchain testing.

@swift-ci Please test nightly self hosted

shahmishal pushed a commit that referenced this issue Dec 18, 2024
Make changes to ensure success of the self-hosted macOS pipeline that
executes using the nightly toolchain.

### Motivation:

When enabling the nightly toolchain build, the CI build does not set
SDKROOT environment variable on Darwin, which causes some tests to fail

### Modifications:

1. Set SDKROOT in build-using-self when on Darwin. When using the
nightly toolchain, the `SDKROOT` environment variable was not set.
Explicitely set this to the default xcode installation only when on
Darwin.
2. Run the testTestsCanLinkAgainstAsyncExecutable only if it's executed
on macOS 15 or never.
3. Add additional logging to troubleshoot the bootstap failure and
convert to use python's logging module instead of print statements.

Verifies #8137
@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 20, 2024

The self-hosted macOS pipeline using the nightly toolchain is now a required pipeline.

Screenshot 2024-12-19 at 9 32 23 PM

Closing this issue as it has been fixed.

@bkhouri bkhouri closed this as completed Dec 20, 2024
@bkhouri bkhouri added the continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines
Projects
None yet
Development

No branches or pull requests

2 participants