Add visionOS as a platform alongside iOS, tvOS, watchOS, and the others
#6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the others Add new enum constants for visionOS in all the places where it is appropriate. This includes the `platforms` parameter in the manifest, whose purpose is to list the minimum deployment targets that a package requires. Since there is initially only visionOS 1.0, and because absence of a platform in the `platforms` parameter means that the default version is supported (not that the platform is unsupported), all packages implicitly support visionOS 1.0 whether or not they list it in the `platforms` parameter. But having the enum constant alongside those for the other Apple platforms makes everything consistent, and will become important for any future versions. This change also makes the `visionOS` platform available for use in conditional target dependencies. rdar://107064954
abertelrud
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
neonichu
approved these changes
Jun 21, 2023
MaxDesiatov
approved these changes
Jun 21, 2023
abertelrud
added a commit
to abertelrud/swift-package-manager
that referenced
this pull request
Jun 21, 2023
…the others (swiftlang#6662) Add new enum constants for visionOS in all the places where it is appropriate. This includes the `platforms` parameter in the manifest, whose purpose is to list the minimum deployment targets that a package requires. Since there is initially only visionOS 1.0, and because absence of a platform in the `platforms` parameter means that the default version is supported (not that the platform is unsupported), all packages implicitly support visionOS 1.0 whether or not they list it in the `platforms` parameter. But having the enum constant alongside those for the other Apple platforms makes everything consistent, and will become important for any future versions. This change also makes the `visionOS` platform available for use in conditional target dependencies. rdar://107064954 (cherry picked from commit 809cb15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new enum constants for visionOS in all the places where it is appropriate.
This includes the
platformsparameter in the manifest, whose purpose is to list the minimum deployment targets that a package requires. Since there is initially only visionOS 1.0, and because absence of a platform in theplatformsparameter means that the default version is supported (not that the platform is unsupported), all packages implicitly support visionOS 1.0 whether or not they list it in theplatformsparameter. But having the enum constant alongside those for the other Apple platforms makes everything consistent, and will become important for any future versions.This change also makes the
visionOSplatform available for use in conditional target dependencies.Motivation:
Xcode 15 Beta 2, released earlier today, includes support for the new
visionOSplatform, and this change aligns SwiftPM with that. Note that this does not mean you can develop visionOS apps with SwiftPM CLI — support is at the same level as for iOS, tvOS, etc, which is that the platform can be mentioned in the manifest, and that when using the experimentalxcbuildbuild system, building libraries for visionOS will be supported at the same level as iOS, tvOS, etc provided that a suitable Xcode is installed.Modifications:
visionOSwherever iOS, tvOS, watchOS, etc are definedPackageDescription.docc/Curation/SupportedPlatforms.md(courtesy of @zkiraly)rdar://107064954