[Build] Adjust computeLLBuildTargetName to attempt host destinati…
#7619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
…on for test products Just like macros and plugins, tests products can also be built for the host depending on their test target(s) destinations (which are inferred based on dependencies). In order to properly support `--test-product` option we need to fallback to `host` lookup for test products just like we do for macros and plugins.
xedin
force-pushed
the
fix-test-product-option-support
branch
from
621a8dc to
f5a5424
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bnbarham
approved these changes
May 31, 2024
xedin
added a commit
that referenced
this pull request
Jun 7, 2024
#7619) …on for test products ### Motivation: Just like macros and plugins, tests products can also be built for the host depending on their test target(s) destinations (which are inferred based on dependencies). In order to properly support `--test-product` option we need to fallback to `host` lookup for test products just like we do for macros and plugins. ### Modifications: - Added a fallback lookup to `computeLLBuildTargetName` ### Result: `--test-product` now supports both `host` and `target` destination products.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on for test products
Motivation:
Just like macros and plugins, tests products can also be built for the host depending on their test target(s) destinations (which are inferred based on dependencies). In order to properly support
--test-productoption we need to fallback tohostlookup for test products just like we do for macros and plugins.Modifications:
computeLLBuildTargetNameResult:
--test-productnow supports bothhostandtargetdestination products.