[Build/PackageGraph] Switch BuildSubset.{product, target} and `Modu…
#7650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
added
build system
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
MaxDesiatov
reviewed
Jun 10, 2024
MaxDesiatov
approved these changes
Jun 10, 2024
…lesGraph.{product, target}(...)` to use optional destination
This is mostly an NFC change. It makes more sense to default `destination`
to "undefined" when applicable because it's not always possible to know
intended destination based on user input.
xedin
force-pushed
the
make-buildset-optional-destination
branch
from
49ce2e5 to
3f4d7ef
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
xedin
added a commit
that referenced
this pull request
Jun 14, 2024
…`Modu… (#7668) …lesGraph.{product, target}(...)` to use optional destination - Explanation: Follow-up to #7646 This is mostly NFC change. It makes more sense to default `destination` to "undefined" when applicable because it's not always possible to know intended destination based on user input. This kind of design makes more sense for internal APIs, instead of having users to pass `.destination` even though it might not be always correct. - Main Branch PRs: #7650 - Risk: Very Low - Reviewed By: @MaxDesiatov - Testing: Existing test-cases were modified and new tests were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lesGraph.{product, target}(...)` to use optional destination
This is mostly an NFC change. It makes more sense to default
destinationto "undefined" when applicable because it's not always possible to know intended destination based on user input.Motivation:
This kind of design makes more sense for internal APIs, instead of having users to pass
.destinationeven though it might not be always correct.Modifications:
BuildSubset.{product, target}andModulesGraph.{product, target}(...)accept an optionaldestinationthat is defaulted to.noneResult:
Easier to understand and use APIs to request a build subset and product and module references from the modules graph.