Fix registry package swizzling when package name casing differs #8194
+68
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix registry package swizzling when package name casing differs
Motivation:
When swizzling dependencies when running
swift package --replace-scm-with-registry resolve
, package references that have different casing don't get swizzled.You can find an example of this scenario in the Firebase SDK that boils down to:
The
.product(name: "FBLPromises", package: "Promises")
should be swizzled to use thegoogle.promises
identifier, but because of the different casing, it's not.Modifications:
When creating the map for packages to be swizzled, make the key lowercase. When we access the map, we again use a lowercase variant of the package name, so we don't unexpectedly miss an entry because of a different casing.
Result:
Packages with different casing are swizzled when using the
swift package --replace-scm-with-registry resolve
command.