-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility: Introduce command repeater script #8227
base: main
Are you sure you want to change the base?
Utility: Introduce command repeater script #8227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason this is written in Bash instead of Python or Swift? What's the plan for running this utility on Windows?
Additionally, what's the goal of this script in general? Is this supposed to be used on CI or locally? I see it measures completion time, which is not meaningful to measure on CI in the vast majority of cases. Then if it's only for local use, why prefer this instead of existing utilities like |
I have been using it to determine if my changes introduced intermittent test failures. I wrote it in bash as that was alot easier to get started. I originally created this is bash as I was using it for myself for a while and didn't want to copy it from one worktree to the next. We can investigate converting to Swift or Python at a later date, if it is deems to be useful enough. The timing calculations were adding for information purposes.
I did not know about
|
The more I think about it, the more I like the idea of creating a python script. I'm converting this PR to draft to work on this. |
7cade49
to
35cccb2
Compare
4a2aee4
to
d640fc7
Compare
cc9ac5e
to
ce43cb7
Compare
Introduce a command repeater script to help run a set of commands repeatedly. Also, enforce black formatting, flake8 linting and mypy type checking on `Utilities/repeat_command` via the `Utilities/build-using-self` script, which is executed in the self-hosted CI pipelines.
ce43cb7
to
54a56db
Compare
Introduce a command repeater script to help run a set of commands repeatedly.
Downside: