Basics,_AsyncFileSystem: internalise SystemPackage #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SystemPackage` is only used as an internal implementation detail here. This package is not needed for the public API surface. Furthermore, as this dependency is a single use dependency, we are able to save some nominal space on the builds with this: Pre: SystemPackage.dll: 212992 bytes _AsyncFileSystem.dll: 60416 bytes Post: SystemPackage.dll: 0 bytes (static) _AsyncFileSystem.dll: 217600 This effectively shaves ~56K off the toolchain.
compnerd
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
|
@swift-ci please test |
compnerd
added a commit
to compnerd/sourcekit-lsp
that referenced
this pull request
Jan 17, 2025
The swift-system package is not used in SourceKit LSP. It was required to fulfil the dependencies for swift-package-manager. With the changes in swiftlang/swift-package-manager#8231 which internalised the SystemPackage import, we no longer need this to be provided.
This was referenced Jan 17, 2025
jakepetroules
approved these changes
Jan 17, 2025
compnerd
added a commit
to swiftlang/sourcekit-lsp
that referenced
this pull request
Jan 20, 2025
The swift-system package is not used in SourceKit LSP. It was required to fulfil the dependencies for swift-package-manager. With the changes in swiftlang/swift-package-manager#8231 which internalised the SystemPackage import, we no longer need this to be provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemPackageis only used as an internal implementation detail here. This package is not needed for the public API surface. Furthermore, as this dependency is a single use dependency, we are able to save some nominal space on the builds with this:Pre:
SystemPackage.dll: 212992 bytes
_AsyncFileSystem.dll: 60416 bytes
Post:
SystemPackage.dll: 0 bytes (static)
_AsyncFileSystem.dll: 217600
This effectively shaves ~56K off the toolchain.