[Experimental][DNM] Use SwiftSystem for file operations #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevapple
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
tomerd
reviewed
Jun 7, 2021
| ] | ||
| }, | ||
| "version": 1 | ||
| } |
tomerd
reviewed
Jun 7, 2021
| default: | ||
| self.init(.unknownOSError, path) | ||
| case .permissionDenied: return .invalidAccess | ||
| case .isDirectory: return.isDirectory |
tomerd
reviewed
Jun 7, 2021
| #endif | ||
| filepath.root = base.filepath.root | ||
|
|
||
| let commonAncestor = AbsolutePath(filepath).lowestCommonAncestor(with: base)! |
There was a problem hiding this comment.
guard + precondition instead of bang?
There was a problem hiding this comment.
I don’t think callers should guard such condition🤔 Breaking is quite reasonable and necessary here.
We’d better discuss in #219 since this API change is introduced there.
tomerd
reviewed
Jun 7, 2021
|
@stevapple @compnerd we now have swift-system integrated into the main branch of TSC and can start making use of it / reduce code to help support windows paths etc better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to use
SwiftSystemfor file operations inTSCBasic, which are currently based onTSClibc.It is based on #219 .
This will:
Discussion: Do we really need a buffer for I/O?
TBD: (mostly
SwiftSystemside)FileDescriptortoFILEbridge.