Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSCBasic: handle empty paths in WindowsPath(validatingRelativePath:) #403

Merged
merged 3 commits into from
Apr 13, 2023
Merged

TSCBasic: handle empty paths in WindowsPath(validatingRelativePath:) #403

merged 3 commits into from
Apr 13, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 5, 2023

We may not invoke fileSystemRepresentation on an empty string as per the API contract for the function. Add guards to prevent that. In order to make this behaviour consistency more visible, reorder the constructors to collate the absolute path and relative path handling.

@compnerd
TSCBasic: handle empty paths in WindowsPath(validatingRelativePath:)
a13b389 
We may not invoke `fileSystemRepresentation` on an empty string as per
the API contract for the function.  Add guards to prevent that.  In
order to make this behaviour consistency more visible, reorder the
constructors to collate the absolute path and relative path handling.
@compnerd
Copy link
Member Author

compnerd commented Apr 5, 2023

@swift-ci please test

@compnerd compnerd enabled auto-merge (squash) April 5, 2023 16:03
@compnerd
Copy link
Member Author

compnerd commented Apr 5, 2023

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Apr 5, 2023

@swift-ci please test macOS platform

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Apr 5, 2023 •
edited
Loading

AFAIU macOS job is going to fail until macOS CI nodes are updated to a later version of Xcode that supports Swift 5.7. cc @shahmishal

@etcwilde
Copy link
Contributor

etcwilde commented Apr 5, 2023

macOS Failure:

/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager: error: package at '/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager' is using Swift tools version 5.7.0 but the installed version is 5.5.0

@etcwilde
Copy link
Contributor

etcwilde commented Apr 5, 2023

AFAIU macOS job is going to fail until macOS CI nodes are updated to a later version of Xcode that supports Swift 5.7. cc @shahmishal

Yeah, that comment looks consistent with the macOS build failure.

@compnerd
Copy link
Member Author

compnerd commented Apr 6, 2023

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Apr 6, 2023

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Apr 6, 2023

CC: @shahmishal:

/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager: error: package at '/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager' is using Swift tools version 5.7.0 but the installed version is 5.5.0

@compnerd
Copy link
Member Author

compnerd commented Apr 7, 2023

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Apr 7, 2023

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test macOS platfom

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

3 similar comments
@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@MaxDesiatov
Copy link
Contributor

@swift-ci test macos

1 similar comment
@MaxDesiatov
Copy link
Contributor

@swift-ci test macos

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

1 similar comment
@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@MaxDesiatov
Copy link
Contributor

@swift-ci test macos

@compnerd compnerd merged commit 4683dfa into swiftlang:main Apr 13, 2023
@compnerd compnerd deleted the im-empty-inside branch April 13, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compnerd @MaxDesiatov @etcwilde @neonichu @tristanlabelle