Change hasQuarantineAttribute(_:) to hasAttribute(_:_:)
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci test |
|
@swift-ci test |
MaxDesiatov
commented
Apr 21, 2023
| @@ -347,9 +347,9 @@ private struct LocalFileSystem: FileSystem { | |||
| return FileInfo(attrs) | |||
| } | |||
|
|
|||
| func hasQuarantineAttribute(_ path: AbsolutePath) -> Bool { | |||
| func hasAttribute(name: String, _ path: AbsolutePath) -> Bool { | |||
| #if canImport(Darwin) | |||
There was a problem hiding this comment.
Doesn't look like getxattr is available with import Glibc so I'm not adding a check for Linux in this condition for now.
There was a problem hiding this comment.
Ah, okay; that seems like a different bug to resolve separately.
|
@swift-ci test windows |
|
@swift-ci clean test macos |
compnerd
approved these changes
Apr 21, 2023
| @@ -347,9 +347,9 @@ private struct LocalFileSystem: FileSystem { | |||
| return FileInfo(attrs) | |||
| } | |||
|
|
|||
| func hasQuarantineAttribute(_ path: AbsolutePath) -> Bool { | |||
| func hasAttribute(name: String, _ path: AbsolutePath) -> Bool { | |||
| #if canImport(Darwin) | |||
There was a problem hiding this comment.
Ah, okay; that seems like a different bug to resolve separately.
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci clean test macos |
|
@swift-ci test macos |
neonichu
approved these changes
Apr 21, 2023
|
@swift-ci test macos |
MaxDesiatov
force-pushed
the
maxd/has-attribute
branch
from
04acdab
to
e93cb40
Compare
|
@swift-ci test |
MaxDesiatov
changed the title
hasQuarantineAttribute(_:) to hasAttribute(name:_:)hasQuarantineAttribute(_:) to hasAttribute(_:_:)
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
tomerd
approved these changes
May 10, 2023
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the attribute reading API more generic as discussed at #412 (comment)