Update requirements in Package.swift to match SwiftPM
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
tomerd
approved these changes
Apr 24, 2023
neonichu
approved these changes
Apr 24, 2023
|
@swift-ci please test |
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
We no longer support Swift 5.5 and older versions of macOS with SwiftPM, makes sense to bring TSC requirements in line with that.
MaxDesiatov
force-pushed
the
maxd/update-package-swift
branch
from
fd3832a
to
d809bad
Compare
|
@swift-ci test |
tomerd
reviewed
May 15, 2023
Package.swift
Outdated
| @@ -18,7 +18,7 @@ let macOSPlatform: SupportedPlatform | |||
| if let deploymentTarget = ProcessInfo.processInfo.environment["SWIFTTSC_MACOS_DEPLOYMENT_TARGET"] { | |||
| macOSPlatform = .macOS(deploymentTarget) | |||
| } else { | |||
| macOSPlatform = .macOS(.v10_13) | |||
| macOSPlatform = .macOS("12.0") | |||
There was a problem hiding this comment.
Do you mean the existing enum case? I was only replicating what SwiftPM already has and thought that one uses strings for a reason. AFAIR @neonichu made those changes in SwiftPM and maybe could clarify the reasoning for raw string preference?
There was a problem hiding this comment.
I think I may have made the platform change before changing the tools-version, so the enum case wasn't available. Definitely no deeper reasoning behind it.
tomerd
reviewed
May 15, 2023
Package.swift
Outdated
| @@ -27,6 +27,7 @@ let package = Package( | |||
| name: "swift-tools-support-core", | |||
| platforms: [ | |||
| macOSPlatform, | |||
| .iOS("15.0") | |||
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test macos |
|
@swift-ci test windows |
|
@swift-ci test macos |
The swift-stress-tester package has 10.15 requirement, which we can match without making more changes in that package.
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
added a commit
that referenced
this pull request
Aug 22, 2024
This reverts commit be6f396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer support Swift 5.5 and older versions of macOS with SwiftPM, makes sense to bring TSC requirements in line with that.