[5.9] Fix macOS build issues #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Potential workaround for a CI issue
The macOS CI does not seem to work with Xcode 14.2 as superior, hitting
```
error: Error Domain=NSCocoaErrorDomain Code=4 "The file "swiftpm" doesn't exist." UserInfo={NSFilePath=/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-tools-support-core/Utilities/ci.xcworkspace/xcshareddata/swiftpm, NSUnderlyingError=0x600000a5a310 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
```
I have a theory that this is triggered by us using a workspace that does not contain a resolved file, but that case works for me with SwiftPM 5.9 locally, so not sure.
* Use python 3
macOS 12 comes with updated python.
We only added the resolved file as a workaround, we may not need any concrete pins for that.
MaxDesiatov
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci test |
This was referenced May 11, 2023
Merged
neonichu
approved these changes
May 11, 2023
tomerd
reviewed
May 11, 2023
| ] | ||
| }, | ||
| "version": 1 | ||
| } |
There was a problem hiding this comment.
We previously saw build failures without it, IIRC @neonichu already committed this on main?
There was a problem hiding this comment.
oh yea, I was hoping we did not need this workaround. @neonichu ?
There was a problem hiding this comment.
We do until we install a new Xcode that doesn't suffer from the problem. I haven't investigated which versions specifically hit the problem, but wasn't able to reproduce with the current release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS build failures currently block PRs against
release/5.9branch. These were fixed inmain, but still need to be cherry-picked for the release branch.